Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string_scalar stream usage in write_json.cu #13212

Merged

Conversation

davidwendt
Copy link
Contributor

Description

Fixes stream usage for cudf::string_scalar variables used in write_json.cu. The passed-in stream should be used instead of the default stream supplied by the string_scalar constructor. Also removed some unused variables. A couple of strings are hardcoded and so these were moved to device code as constants to avoid the host-to-copy that occurs within the string_scalar constructor.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 25, 2023
@davidwendt davidwendt self-assigned this Apr 25, 2023
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍
Thank you for catching this!

cpp/src/io/json/write_json.cu Outdated Show resolved Hide resolved
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Apr 26, 2023
@davidwendt davidwendt marked this pull request as ready for review April 26, 2023 22:30
@davidwendt davidwendt requested a review from a team as a code owner April 26, 2023 22:30
@harrism harrism removed their request for review April 27, 2023 00:01
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit fd1afc8 into rapidsai:branch-23.06 Apr 27, 2023
@davidwendt davidwendt deleted the scalar-stream-json-writer branch April 27, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants